Conversation
|
mf4-io can probably be deleted, should this be merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1289 +/- ##
===========================================
+ Coverage 65.16% 65.60% +0.44%
===========================================
Files 81 82 +1
Lines 8853 9074 +221
===========================================
+ Hits 5769 5953 +184
- Misses 3084 3121 +37 |
|
@driftregion can i force push to this PR? |
|
@zariiii9003 sure, go ahead. |
|
@danielhrisca would it be possible to stream to a file directly? |
The only way to
|
|
@danielhrisca The BlfWriter compresses and writes data in chunks so maybe that could be possible here too? |
setup.py
Outdated
There was a problem hiding this comment.
I'm going to remove the platform and python version requirements unless there is a good reason not to?
There was a problem hiding this comment.
I think i added this so CI does not fail on PyPy and CPython 3.11. But there's probably a better solution for that. I admit this is ugly.
| """ | ||
| Iterator of CAN messages from a MF4 logging file. | ||
|
|
||
| The MF4Reader only supports MF4 files that were recorded with python-can. |
# Conflicts: # can/__init__.py # can/io/__init__.py # can/io/logger.py # can/io/player.py
|
@danielhrisca merged after only 3.5 years 💪 |
|
It's like a good wine |
I rebased #554
Closes #506